[Merged by Bors] - don't panic when no RenderResourceContext can be found #1971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mockersf
force-pushed
the
dont-panic-webgl2-RenderResourceContext
branch
from
a6facbe
to
dfaf6bf
Compare
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 20, 2021
In bevy_webgl2, the `RenderResourceContext` is created after startup as it needs to first wait for an event from js side: https://github.com/mrk-its/bevy_webgl2/blob/f31e5d49def7de6bfe58a47587e7ab3ca349da05/src/lib.rs#L117 remove `panic` introduced in #1965 and log as a `warn` instead
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
ostwilkens
pushed a commit
to ostwilkens/bevy
that referenced
this pull request
Jul 27, 2021
In bevy_webgl2, the `RenderResourceContext` is created after startup as it needs to first wait for an event from js side: https://github.com/mrk-its/bevy_webgl2/blob/f31e5d49def7de6bfe58a47587e7ab3ca349da05/src/lib.rs#L117 remove `panic` introduced in bevyengine#1965 and log as a `warn` instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In bevy_webgl2, the
RenderResourceContextis created after startup as it needs to first wait for an event from js side:https://github.com/mrk-its/bevy_webgl2/blob/f31e5d49def7de6bfe58a47587e7ab3ca349da05/src/lib.rs#L117
remove
panicintroduced in #1965 and log as awarninstead