Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Provide better size_hint for QueryIter #1697

Closed
wants to merge 1 commit into from

Conversation

MinerSebas
Copy link
Contributor

This PR overrides the default size_hint for QueryIter.
This is mainly done to provide inline documentation of Issue #1686.

@alice-i-cecile alice-i-cecile added the C-Code-Quality A section of code that is hard to understand or change label Mar 19, 2021
@alice-i-cecile alice-i-cecile added the A-ECS Entities, components, systems, and events label Mar 19, 2021
@cart
Copy link
Member

cart commented Mar 19, 2021

bors r+

bors bot pushed a commit that referenced this pull request Mar 19, 2021
This PR overrides the default size_hint for QueryIter.
This is mainly done to provide inline documentation of Issue #1686.
@bors bors bot changed the title Provide better size_hint for QueryIter [Merged by Bors] - Provide better size_hint for QueryIter Mar 19, 2021
@bors bors bot closed this Mar 19, 2021
@MinerSebas MinerSebas deleted the queryiter_sizehint branch March 20, 2021 13:13
bors bot pushed a commit that referenced this pull request Apr 13, 2021
… applicable (#1734)

After #1697 I looked at all other Iterators from Bevy and added overrides for `size_hint` where it wasn't done.
Also implemented `ExactSizeIterator` where applicable.
jihiggins pushed a commit to jihiggins/bevy that referenced this pull request Apr 18, 2021
… applicable (bevyengine#1734)

After bevyengine#1697 I looked at all other Iterators from Bevy and added overrides for `size_hint` where it wasn't done.
Also implemented `ExactSizeIterator` where applicable.
ostwilkens pushed a commit to ostwilkens/bevy that referenced this pull request Jul 27, 2021
… applicable (bevyengine#1734)

After bevyengine#1697 I looked at all other Iterators from Bevy and added overrides for `size_hint` where it wasn't done.
Also implemented `ExactSizeIterator` where applicable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants