Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose BRP system scheduling and add system set #16400

Merged
merged 2 commits into from
Nov 16, 2024
Merged

Expose BRP system scheduling and add system set #16400

merged 2 commits into from
Nov 16, 2024

Conversation

villor
Copy link
Contributor

@villor villor commented Nov 16, 2024

Objective

When adding custom BRP methods one might need to:

  • Run custom systems in the RemoteLast schedule.
  • Order those systems before/after request processing and cleanup.

For example in bevy_remote_inspector we need a way to perform some preparation before request processing. And to perform cleanup between request processing and watcher cleanup.

Solution

  • Make RemoteLast public
  • Add RemoteSet with ProcessRequests and Cleanup variants.

mweatherley
mweatherley approved these changes Nov 16, 2024
View reviewed changes
Copy link
Contributor

@mweatherley mweatherley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for your continued work on this :)

@mweatherley mweatherley added C-Feature A new feature, making something new possible C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Editor Graphical tools to make Bevy games S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Nov 16, 2024
@mockersf mockersf added this pull request to the merge queue Nov 16, 2024
@mockersf mockersf added this to the 0.15 milestone Nov 16, 2024
Merged via the queue into bevyengine:main with commit 9f04fc0 Nov 16, 2024
34 checks passed
mockersf pushed a commit that referenced this pull request Nov 17, 2024
@villor @mockersf
Expose BRP system scheduling and add system set (#16400)
d0f755d 
# Objective
When adding custom BRP methods one might need to:
- Run custom systems in the `RemoteLast` schedule.
- Order those systems before/after request processing and cleanup.

For example in `bevy_remote_inspector` we need a way to perform some
preparation _before_ request processing. And to perform cleanup
_between_ request processing and watcher cleanup.

## Solution

- Make `RemoteLast` public
- Add `RemoteSet` with `ProcessRequests` and `Cleanup` variants.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@mweatherley mweatherley mweatherley approved these changes

Assignees
No one assigned
Labels
A-Editor Graphical tools to make Bevy games C-Feature A new feature, making something new possible C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Needs-Review Needs reviewer attention (from anyone!) to move forward
Projects
None yet
Milestone
0.15
Development

Successfully merging this pull request may close these issues.
3 participants
@villor @mweatherley @mockersf