Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary division in compute_smooth_normals #16039

Merged
merged 1 commit into from
Oct 20, 2024
Merged

Unnecessary division in compute_smooth_normals #16039

merged 1 commit into from
Oct 20, 2024

Conversation

stepancheg
Copy link
Contributor

@stepancheg stepancheg commented Oct 20, 2024 •
edited
Loading

Objective

  • Less code
  • Simpler code

Solution

  • Remove unnecessary division: normalize already does that

Testing

@stepancheg stepancheg changed the title Compute smooth normals div Unnecessary division in compute_smooth_normals Oct 20, 2024
@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change A-Math Fundamental domain-agnostic mathematical operations D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 20, 2024
IceSentry
IceSentry approved these changes Oct 20, 2024
View reviewed changes
Copy link
Contributor

@IceSentry IceSentry left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on this https://iquilezles.org/articles/normals/ article we should also be able to skip the normalize in face_normal, but I'm not sure if that may break the flat normals.

@IceSentry IceSentry added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 20, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 20, 2024
Merged via the queue into bevyengine:main with commit 472bbaa Oct 20, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@IceSentry IceSentry IceSentry approved these changes

Assignees
No one assigned
Labels
A-Math Fundamental domain-agnostic mathematical operations A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
Rendering
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stepancheg @alice-i-cecile @IceSentry