Add a test for Mesh::triangles and fix for TriangleStrip #16026
Merged
+106
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Bug
alice-i-cecile
approved these changes
Oct 20, 2024
stepancheg
force-pushed
the
mesh-triangles
branch
from
4090170
to
20a9344
Compare
stepancheg
force-pushed
the
mesh-triangles
branch
from
20a9344
to
4889b49
Compare
mweatherley
approved these changes
Oct 21, 2024
| } else { | ||
| indices_to_triangle( | ||
| vertices, | ||
| &[indices[1], indices[0], indices[2]], |
There was a problem hiding this comment.
In bevy_math, we currently reverse the orientation of Triangle3d by swapping the first and last vertices; maybe these should be consistent with that?
There was a problem hiding this comment.
I followed documentation for PrimitiveTopology::TriangleStrip which says:
Vertices 0 1 2 3 4 5 create four triangles 0 1 2, 2 1 3, 2 3 4, and 4 3 5
alice-i-cecile
added
S-Ready-For-Final-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Testing
Test added.