[Merged by Bors] - Docs for Bundle showing how to nest bundles #1570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Docs
#1525 accidentally moved back to rand 0.7
cart
reviewed
Mar 6, 2021
cart
reviewed
Mar 6, 2021
mockersf
requested changes
Mar 6, 2021
Fix staging buffer required size calculation (fixes #1056) The `required_staging_buffer_size` is currently calculated differently in two places, each will be correct in different situations: * `prepare_staging_buffers()` based on actual `buffer_byte_len()` * `set_required_staging_buffer_size_to_max()` based on item_size In the case of render assets, `prepare_staging_buffers()` would only operate over changed assets. If some of the assets didn't change, their size wouldn't be taken into account for the `required_staging_buffer_size`. In some cases, this meant the buffers wouldn't be resized when they should. Now `prepare_staging_buffers()` is called over all assets, which may hit performance but at least gets the size right. Shortly after `prepare_staging_buffers()`, `set_required_staging_buffer_size_to_max()` would unconditionally overwrite the previously computed value, even if using `item_size` made no sense. Now it only overwrites the value if bigger. This can be considered a short term hack, but should prevent a few hard to debug panics.
Added extra space, and hid user-inappropriate import.
Added extra space, and hid user-inappropriate import.
|
for future reference: rebasing instead of merging helps avoid pulling changes from |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 6, 2021
I've also added a clearer description of what bundles are used for, and explained that you can't query for bundles (a very common beginner confusion). Co-authored-by: MinerSebas <[email protected]> Co-authored-by: Renato Caldas <[email protected]>
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Closed
This was referenced Mar 7, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've also added a clearer description of what bundles are used for, and explained that you can't query for bundles (a very common beginner confusion).