Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Math tests fix #12748

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Math tests fix #12748

merged 2 commits into from
Mar 27, 2024

Conversation

bugsweeper
Copy link
Contributor

@bugsweeper bugsweeper commented Mar 27, 2024 •
edited
Loading

Objective

Fixes cargo test -p bevy_math as in #12729.

Solution

As described in message
Added workaround bevy_math = { path = ".", version = "0.14.0-dev", features = ["approx"] } to bevy_math's dev-dependencies

@pablo-lua pablo-lua added C-Bug An unexpected or incorrect behavior C-Testing A change that impacts how we test Bevy or how users test their apps A-Math Fundamental domain-agnostic mathematical operations labels Mar 27, 2024
BD103
BD103 approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@BD103 BD103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Could you please test if the release and post-release jobs will automatically upgrade the version number to 0.14, 0.15-dev, etc?

crates/bevy_math/Cargo.toml Show resolved Hide resolved
@bugsweeper @BD103
Update crates/bevy_math/Cargo.toml
dd09633 
Add explanation comment

Co-authored-by: BD103 <[email protected]>
@pablo-lua pablo-lua added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Mar 27, 2024
@bugsweeper
Copy link
Contributor Author

Looks good! Could you please test if the release and post-release jobs will automatically upgrade the version number to 0.14, 0.15-dev, etc?

Checked cargo-release, which used in release and post-release jobs, in both cases successfully upgrades version number for this dependency line

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Mar 27, 2024
Merged via the queue into bevyengine:main with commit c38e2d0 Mar 27, 2024
32 checks passed
@bugsweeper bugsweeper mentioned this pull request Mar 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@BD103 BD103 BD103 approved these changes

Assignees
No one assigned
Labels
A-Math Fundamental domain-agnostic mathematical operations C-Bug An unexpected or incorrect behavior C-Testing A change that impacts how we test Bevy or how users test their apps S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bugsweeper @alice-i-cecile @BD103 @pablo-lua