-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mobile and webgpu: trigger redraw request when needed and improve window creation #11245
Merged
alice-i-cecile
merged 7 commits into
bevyengine:main
from
mockersf:mobile-create-window-on-resume
Jan 9, 2024
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
71a45c6
mobile: create window on initial resume
mockersf b4a872c
don't update on MouseMotion
mockersf 104af29
request update on resume
mockersf 6ecdde6
cleanup
mockersf ea29004
request update during plugin initialization
mockersf a14c92c
cleanup
mockersf 8005aaa
request redraw on ABoutToWait instead of after an event
mockersf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Creating windows outside of
Event::Resumed
for these targets is indeed incorrect.So this change is great!
I would recommend you to move window creation of all targets inside
Event::Resumed
, it would cut down on thecfg
guards.Let me know if there is a reason why this can't be done or isn't desirable!