Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print to stderr from panic handler in LogPlugin #11170

Merged
merged 1 commit into from
Jan 1, 2024

Conversation

stepancheg
Copy link
Contributor

Objective

When panic handler prints to stdout instead of stderr, I've observed two outcomes with this PR test #11169:

  • Sometimes output is mixed up, so it is not clear where one record ends and another stards
  • Sometimes output is lost

Solution

Print to stderr.

Changelog

  • Panic handler in LogPlugin writes to stderr instead of stdin.

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Diagnostics Logging, crash handling, error reporting and performance analysis labels Jan 1, 2024
@alice-i-cecile alice-i-cecile added this to the 0.13 milestone Jan 1, 2024
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jan 1, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 1, 2024
Merged via the queue into bevyengine:main with commit 443b64a Jan 1, 2024
26 checks passed
@stepancheg stepancheg deleted the log-stderr branch January 1, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Diagnostics Logging, crash handling, error reporting and performance analysis C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants