Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove apply_deferred example #11142

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

stepancheg
Copy link
Contributor

@stepancheg stepancheg commented Dec 30, 2023

Objective

Re this comment: #11141 (comment)

Since #9822, Bevy automatically inserts apply_deferred between systems with dependencies where needed, so manually inserted apply_deferred doesn't to anything useful, and in current state this example does more harm than good.

Solution

The example can be modified with removal of automatic apply_deferred insertion, but that would immediately upgrade this example from beginner level, to upper intermediate. Most users don't need to disable automatic sync point insertion, and remaining few who do probably already know how it works.

CC @hymm

@matiqo15 matiqo15 added A-ECS Entities, components, systems, and events C-Examples An addition or correction to our examples labels Dec 30, 2023
Copy link
Member

@JoJoJet JoJoJet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, let's get rid of this. This will be stored in git so we can always bring it back and adapt it if we want to make an example aimed at power users.

@hymm hymm added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jan 5, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 8, 2024
Merged via the queue into bevyengine:main with commit 42e9908 Jan 8, 2024
27 checks passed
@stepancheg stepancheg deleted the rm-apply-deferred branch January 8, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ECS Entities, components, systems, and events C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants