-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clippy warnings #11123
Closed
Closed
Clippy warnings #11123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
approved these changes
Dec 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you!
alice-i-cecile
added
A-Build-System
Related to build systems or continuous integration
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
C-Code-Quality
A section of code that is hard to understand or change
labels
Dec 28, 2023
Merging as trivial to unblock CI. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 28, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 28, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 29, 2023
alice-i-cecile
added
the
P-Critical
This must be fixed immediately or contributors or users will be severely impacted
label
Dec 29, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 29, 2023
atlv24
approved these changes
Dec 30, 2023
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 30, 2023
# Objective Fix ci hang, so we can merge pr's again. ## Solution - switch ppa action to use mesa stable versions https://launchpad.net/~kisak/+archive/ubuntu/turtle - use commit from #11123 --------- Co-authored-by: Stepan Koltsov <[email protected]>
aevyrie
pushed a commit
to aevyrie/bevy
that referenced
this pull request
Jan 3, 2024
# Objective Fix ci hang, so we can merge pr's again. ## Solution - switch ppa action to use mesa stable versions https://launchpad.net/~kisak/+archive/ubuntu/turtle - use commit from bevyengine#11123 --------- Co-authored-by: Stepan Koltsov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Build-System
Related to build systems or continuous integration
C-Code-Quality
A section of code that is hard to understand or change
P-Critical
This must be fixed immediately or contributors or users will be severely impacted
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whatever popped up while running
Clippy warnings block merging of PRs for example, #11110.
Fixes #11121.