Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clippy warnings #11123

Closed
wants to merge 1 commit into from
Closed

Clippy warnings #11123

wants to merge 1 commit into from

Conversation

stepancheg
Copy link
Contributor

@stepancheg stepancheg commented Dec 28, 2023

Whatever popped up while running

cargo clippy --workspace --all-targets --all-features -- -Dwarnings

Clippy warnings block merging of PRs for example, #11110.

Fixes #11121.

Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@alice-i-cecile alice-i-cecile added A-Build-System Related to build systems or continuous integration S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it C-Code-Quality A section of code that is hard to understand or change labels Dec 28, 2023
@alice-i-cecile
Copy link
Member

Merging as trivial to unblock CI.

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Dec 28, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 28, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Dec 28, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 28, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Dec 29, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 29, 2023
@cart cart added this pull request to the merge queue Dec 29, 2023
@alice-i-cecile alice-i-cecile added the P-Critical This must be fixed immediately or contributors or users will be severely impacted label Dec 29, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 29, 2023
@hymm hymm mentioned this pull request Dec 30, 2023
github-merge-queue bot pushed a commit that referenced this pull request Dec 30, 2023
# Objective

Fix ci hang, so we can merge pr's again.

## Solution

- switch ppa action to use mesa stable versions
https://launchpad.net/~kisak/+archive/ubuntu/turtle
- use commit from #11123

---------

Co-authored-by: Stepan Koltsov <[email protected]>
aevyrie pushed a commit to aevyrie/bevy that referenced this pull request Jan 3, 2024
# Objective

Fix ci hang, so we can merge pr's again.

## Solution

- switch ppa action to use mesa stable versions
https://launchpad.net/~kisak/+archive/ubuntu/turtle
- use commit from bevyengine#11123

---------

Co-authored-by: Stepan Koltsov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Build-System Related to build systems or continuous integration C-Code-Quality A section of code that is hard to understand or change P-Critical This must be fixed immediately or contributors or users will be severely impacted S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

manual_hash_one lint causing CI failures
3 participants