Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce noise in asset processing example #10262

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Reduce noise in asset processing example #10262

merged 3 commits into from
Oct 25, 2023

Conversation

NiklasEi
Copy link
Member

Objective

  • Reduce noise to allow users to see previous asset changes and other logs like from asset reloading
  • The example file is named differently than the example

Solution

  • Only print the asset content if there are asset events
  • Rename the example file to asset_processing

@alice-i-cecile alice-i-cecile added C-Examples An addition or correction to our examples A-Assets Load files from disk to use for things like images, models, and sounds S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Oct 25, 2023
@alice-i-cecile
Copy link
Member

Merging as trivial :) Thanks!

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 25, 2023
Merged via the queue into bevyengine:main with commit 317903f Oct 25, 2023
25 checks passed
ameknite pushed a commit to ameknite/bevy that referenced this pull request Nov 6, 2023
@NiklasEi @ameknite
Reduce noise in asset processing example (bevyengine#10262)
1ca305c 
# Objective

- Reduce noise to allow users to see previous asset changes and other
logs like from asset reloading
- The example file is named differently than the example

## Solution

- Only print the asset content if there are asset events
- Rename the example file to `asset_processing`
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@NiklasEi
Reduce noise in asset processing example (bevyengine#10262)
512142b 
# Objective

- Reduce noise to allow users to see previous asset changes and other
logs like from asset reloading
- The example file is named differently than the example

## Solution

- Only print the asset content if there are asset events
- Rename the example file to `asset_processing`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Assets Load files from disk to use for things like images, models, and sounds C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NiklasEi @alice-i-cecile