Tidy up UI node docs #10189
Merged
Tidy up UI node docs #10189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rparrett
added
C-Docs
alice-i-cecile
approved these changes
Oct 19, 2023
NoahShomette
approved these changes
Oct 21, 2023
There was a problem hiding this comment.
Several of these are nitpicks, I don't have strong opinions on the clear nitpicks but as long as the documentation of this file is the focus might as well fix the smaller 'errors' while we are here imo. Approving just cuz most of it is small but there are some genuine errors in there are as well
Co-authored-by: Noah <[email protected]>
Co-authored-by: Noah <[email protected]>
Co-authored-by: Noah <[email protected]>
Co-authored-by: Noah <[email protected]>
Co-authored-by: Noah <[email protected]>
|
I think I got all of your feedback incorporated. Thanks! |
CrumbsTrace
reviewed
Oct 21, 2023
alice-i-cecile
added
the
S-Ready-For-Final-Review
robtfm
pushed a commit
to robtfm/bevy
that referenced
this pull request
Oct 23, 2023
# Objective While reviewing bevyengine#10187 I noticed some other mistakes in the UI node docs. ## Solution I did a quick proofreading pass and fixed a few things. And of course, the typo from that other PR. ## Notes I occasionally insert a period to make a section of doc self-consistent but didn't go one way or the other on all periods in the file. --------- Co-authored-by: Noah <[email protected]>
ameknite
pushed a commit
to ameknite/bevy
that referenced
this pull request
Nov 6, 2023
# Objective While reviewing bevyengine#10187 I noticed some other mistakes in the UI node docs. ## Solution I did a quick proofreading pass and fixed a few things. And of course, the typo from that other PR. ## Notes I occasionally insert a period to make a section of doc self-consistent but didn't go one way or the other on all periods in the file. --------- Co-authored-by: Noah <[email protected]>
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
# Objective While reviewing bevyengine#10187 I noticed some other mistakes in the UI node docs. ## Solution I did a quick proofreading pass and fixed a few things. And of course, the typo from that other PR. ## Notes I occasionally insert a period to make a section of doc self-consistent but didn't go one way or the other on all periods in the file. --------- Co-authored-by: Noah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
While reviewing #10187 (404 now, GH banned the user for spam) I noticed some other mistakes in the UI node docs.
Solution
I did a quick proofreading pass and fixed a few things. And of course, the typo from that other PR.
Notes
I occasionally insert a period to make a section of doc self-consistent but didn't go one way or the other on all periods in the file.