bevy_reflect: Fix dynamic type serialization

[MrGVSV]

Objective

Fixes #10086

Solution

Instead of serializing via DynamicTypePath::reflect_type_path, now uses the TypePath found on the TypeInfo returned by Reflect::get_represented_type_info.

This issue was happening because the dynamic types implement TypePath themselves and do not (and cannot) forward their proxy's TypePath data. The solution was to access the proxy's type information in order to get the correct TypePath data.

Changed

• The Debug impl for TypePathTable now includes output for all fields.

[alice-i-cecile]

@raffaeleragni, if you feel equipped, your review / approval would be appreciated here :)

[MrGVSV]

This also has a change to TypePathTable's Debug impl (which was useful for debugging this issue). Maybe also just a thumbs up from @soqb on that?

[raffaeleragni]

Pointing to the fork & branch.
Still having issues, it seems I have to register DynamicStruct in my test registry: registry.register::<DynamicStruct>();, but DynamicStruct not implementing GetTypeRegistration

(my branch is https://github.com/raffaeleragni/bevy_sync/tree/bevy_0_12)

[raffaeleragni]

I see in the new test DynamicStruct is asserted directly, but how do you bring back the TestStruct from deserialization instead? Without knowing its type at compile time, that is.

[raffaeleragni]

My test runs fine too now, thanks.

[raffaeleragni]

As an extra, but this could be unrelated to this PR and require a new one, not sure:

https://github.com/raffaeleragni/bevy_sync/blob/bevy_0_12/src/proto_serde.rs#L148
I am serializing a material too here now, and this happens:

---- proto_serde::test::material_serde stdout ----
thread 'proto_serde::test::material_serde' panicked at src/proto_serde.rs:29:57:
called `Result::unwrap()` on an `Err` value: Custom("no variant found at index `4128768` on enum `bevy_pbr::alpha::AlphaMode`")
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

[MrGVSV]

As an extra, but this could be unrelated to this PR and require a new one, not sure:

https://github.com/raffaeleragni/bevy_sync/blob/bevy_0_12/src/proto_serde.rs#L148

I am serializing a material too here now, and this happens:

---- proto_serde::test::material_serde stdout ----

thread 'proto_serde::test::material_serde' panicked at src/proto_serde.rs:29:57:

called `Result::unwrap()` on an `Err` value: Custom("no variant found at index `4128768` on enum `bevy_pbr::alpha::AlphaMode`")

note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

This seems possibly unrelated. Could you open a new issue?

[raffaeleragni]

Sure

[raffaeleragni]

#10110

[soqb]

LGTM! i like this direction.

[alice-i-cecile]

@MrGVSV those CI failures look real; failing bevy_reflect test.