Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

foxes shouldn't march in sync #10070

Merged
merged 3 commits into from
Oct 9, 2023
Merged

foxes shouldn't march in sync #10070

merged 3 commits into from
Oct 9, 2023

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Oct 9, 2023 •
edited
Loading

Objective

  • All foxes in many_foxes are running in sync
  • It's scary
  • It can also be a source of optimisation that won't be useful in a general case

Solution

  • Advance the animation of each fox so that they are not synced anymore by default
  • Add a cli arg to enable them running in sync

@mockersf mockersf added the C-Examples An addition or correction to our examples label Oct 9, 2023
@mockersf mockersf requested a review from superdump October 9, 2023 22:16
@mockersf mockersf marked this pull request as draft October 9, 2023 22:21
@mockersf mockersf marked this pull request as ready for review October 9, 2023 22:31
@superdump superdump enabled auto-merge October 9, 2023 22:40
@superdump superdump added this pull request to the merge queue Oct 9, 2023
Merged via the queue into bevyengine:main with commit a52ca17 Oct 9, 2023
21 checks passed
regnarock pushed a commit to regnarock/bevy that referenced this pull request Oct 13, 2023
@mockersf
foxes shouldn't march in sync (bevyengine#10070)
a305675 
# Objective

- All foxes in `many_foxes` are running in sync
- It's scary
- It can also be a source of optimisation that won't be useful in a
general case

## Solution

- Advance the animation of each fox so that they are not synced anymore
by default
- Add a cli arg to enable them running in sync
ameknite pushed a commit to ameknite/bevy that referenced this pull request Nov 6, 2023
@mockersf @ameknite
foxes shouldn't march in sync (bevyengine#10070)
8b853bf 
# Objective

- All foxes in `many_foxes` are running in sync
- It's scary
- It can also be a source of optimisation that won't be useful in a
general case

## Solution

- Advance the animation of each fox so that they are not synced anymore
by default
- Add a cli arg to enable them running in sync
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@mockersf
foxes shouldn't march in sync (bevyengine#10070)
b5626cf 
# Objective

- All foxes in `many_foxes` are running in sync
- It's scary
- It can also be a source of optimisation that won't be useful in a
general case

## Solution

- Advance the animation of each fox so that they are not synced anymore
by default
- Add a cli arg to enable them running in sync
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superdump superdump superdump approved these changes

Assignees
No one assigned
Labels
C-Examples An addition or correction to our examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mockersf @superdump