Add an API to manually set change ticks for advanced users #5633
Labels
A-ECS
Entities, components, systems, and events
C-Usability
A targeted quality-of-life change that makes Bevy easier to use
S-Ready-For-Implementation
This issue is ready for an implementation PR. Go for it!
Comments
alice-i-cecile
added
A-ECS
|
For context, any plugins (not just multiplayer) that want to cleanly reset some/all of the data in a Also, this is not something blocking me today, I'm not even that far lol. Another alternative would be attaching your own versions of system and component ticks as |
|
Right; we'll need the ability to muck with system change ticks too. IMO that should be a seperate PR, and be done after the bulk of stageless. |
nicopap
pushed a commit
to nicopap/bevy
that referenced
this issue
Sep 12, 2022
…evyengine#5635) # Objective - Our existing change detection API is not flexible enough for advanced users: particularly those attempting to do rollback networking. - This is an important use case, and with adequate warnings we can make mucking about with change ticks scary enough that users generally won't do it. - Fixes bevyengine#5633. - Closes bevyengine#2363. ## Changelog - added `ChangeDetection::set_last_changed` to manually mutate the `last_change_ticks` field" - the `ChangeDetection` trait now requires an `Inner` associated type, which contains the value being wrapped. - added `ChangeDetection::bypass_change_detection`, which hands out a raw `&mut Inner` ## Migration Guide Add the `Inner` associated type and new methods to any type that you've implemented `DetectChanges` for.
james7132
pushed a commit
to james7132/bevy
that referenced
this issue
Oct 28, 2022
…evyengine#5635) # Objective - Our existing change detection API is not flexible enough for advanced users: particularly those attempting to do rollback networking. - This is an important use case, and with adequate warnings we can make mucking about with change ticks scary enough that users generally won't do it. - Fixes bevyengine#5633. - Closes bevyengine#2363. ## Changelog - added `ChangeDetection::set_last_changed` to manually mutate the `last_change_ticks` field" - the `ChangeDetection` trait now requires an `Inner` associated type, which contains the value being wrapped. - added `ChangeDetection::bypass_change_detection`, which hands out a raw `&mut Inner` ## Migration Guide Add the `Inner` associated type and new methods to any type that you've implemented `DetectChanges` for.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this issue
Feb 1, 2023
…evyengine#5635) # Objective - Our existing change detection API is not flexible enough for advanced users: particularly those attempting to do rollback networking. - This is an important use case, and with adequate warnings we can make mucking about with change ticks scary enough that users generally won't do it. - Fixes bevyengine#5633. - Closes bevyengine#2363. ## Changelog - added `ChangeDetection::set_last_changed` to manually mutate the `last_change_ticks` field" - the `ChangeDetection` trait now requires an `Inner` associated type, which contains the value being wrapped. - added `ChangeDetection::bypass_change_detection`, which hands out a raw `&mut Inner` ## Migration Guide Add the `Inner` associated type and new methods to any type that you've implemented `DetectChanges` for.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What problem does this solve or what need does it fill?
This API is essential to ensure the reliability of change detection with rollback networking.
From @maniwani.
What solution would you like?
Add a
set_last_changedmethod toDetectChanges. This should come with warnings in the docs about the need to carefully think through exactly what you're doing.What alternative(s) have you considered?
Never use change detection in games with rollback networking?
Use a different networking strategy?
Additional context
If we're adding this, we should similarly add a change-detection bypass to avoid users cobbling together an approach to do this by manually setting the change ticks.
This was previously done in #2363, but IMO should be unconditionally enabled instead.
The text was updated successfully, but these errors were encountered: