Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify std:mem::{size_of, size_of_val, align_of, align_of_val} #15314

Closed
BenjaminBrienen opened this issue Sep 19, 2024 · 1 comment · Fixed by #15315
Closed

Simplify std:mem::{size_of, size_of_val, align_of, align_of_val} #15314

BenjaminBrienen opened this issue Sep 19, 2024 · 1 comment · Fixed by #15315
Labels
C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled

Comments

@BenjaminBrienen
Copy link
Contributor

BenjaminBrienen commented Sep 19, 2024 •
edited
Loading

size_of, size_of_val, align_of, and align_of_val are now in the rust prelude: rust-lang/rust#123168

We can clean up references to these functions.

Credit to Pyrious for the idea
@BenjaminBrienen BenjaminBrienen added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Sep 19, 2024
@BenjaminBrienen
Copy link
Contributor Author

Sorry, I chose the wrong issue type

@BenjaminBrienen BenjaminBrienen mentioned this issue Sep 19, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Sep 19, 2024
@BenjaminBrienen
simplify std::mem references (#15315)
1b8c1c1 
# Objective
- Fixes #15314

## Solution

- Remove unnecessary usings and simplify references to those functions.

## Testing

CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

simplify std::mem references BenjaminBrienen/bevy
1 participant
@BenjaminBrienen