Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an example or stress test that focuses on animating materials #11516

Closed
alice-i-cecile opened this issue Jan 24, 2024 · 0 comments · Fixed by #11524
Closed

Add an example or stress test that focuses on animating materials #11516

alice-i-cecile opened this issue Jan 24, 2024 · 0 comments · Fixed by #11524
Labels
A-Rendering Drawing game state to the screen C-Benchmarks Stress tests and benchmarks used to measure how fast things are C-Examples An addition or correction to our examples

Comments

@alice-i-cecile
Copy link
Member 

          As @DGriffin91 [pointed out](https://discord.com/channels/691052431525675048/743663924229963868/1199844494602936491), we should verify that this doesn't cause large performance regressions on more realistic scenes involving animated materials. We don't currently *have* a good example to test that though: lemme make an issue.

Originally posted by @alice-i-cecile in #10610 (comment)

Changing material properties (rather than just handles to a new material) is a powerful and flexible tool for creating visual effects. However, we don't clearly demonstrate this to new users, and also don't have a good tool to detect performance changes here.

We should make an example that demonstrates this in a semi-realistic and appealing way. If it doesn't stress performance adequately, we should also make a stress test.
@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples C-Benchmarks Stress tests and benchmarks used to measure how fast things are labels Jan 24, 2024
@rparrett rparrett mentioned this issue Jan 25, 2024
Closed
@atlv24 atlv24 mentioned this issue Jan 25, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 26, 2024
@atlv24
Add Animated Material example (#11524)
fb367da 
# Objective

- Fixes #11516

## Solution

- Add Animated Material example (colors are hue-cycling smoothly
per-mesh)


![image](https://github.com/bevyengine/bevy/assets/11307157/c75b9e66-0019-41b8-85ec-647559c6ba01)

Note: this example reproduces the perf issue found in #10610 pretty
consistently, with and without the changes from that PR included. Frame
time is sometimes around 4.3ms, other times around 12-14ms. Its pretty
random per run. I think this clears #10610 for merge.
@alice-i-cecile alice-i-cecile mentioned this issue Jan 28, 2024
Open
tjamaan pushed a commit to tjamaan/bevy that referenced this issue Feb 6, 2024
@atlv24 @tjamaan
Add Animated Material example (bevyengine#11524)
16f50c7 
# Objective

- Fixes bevyengine#11516

## Solution

- Add Animated Material example (colors are hue-cycling smoothly
per-mesh)


![image](https://github.com/bevyengine/bevy/assets/11307157/c75b9e66-0019-41b8-85ec-647559c6ba01)

Note: this example reproduces the perf issue found in bevyengine#10610 pretty
consistently, with and without the changes from that PR included. Frame
time is sometimes around 4.3ms, other times around 12-14ms. Its pretty
random per run. I think this clears bevyengine#10610 for merge.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Benchmarks Stress tests and benchmarks used to measure how fast things are C-Examples An addition or correction to our examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Animated Material example atlv24/bevy
1 participant
@alice-i-cecile