Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asset_server.load_folder never creates a LoadedFolder asset if _any_ asset contained errors while loading #10467

Open
RyeToastyO opened this issue Nov 9, 2023 · 2 comments
Labels
A-Assets Load files from disk to use for things like images, models, and sounds C-Bug An unexpected or incorrect behavior

Comments

@RyeToastyO
Copy link

RyeToastyO commented Nov 9, 2023

Bevy version

0.12.0

What you did

Had a typo in a ron custom asset such that ron::de::from_bytes(&bytes)? returned an error

What went wrong

  • what were you expecting?
    LoadedFolder asset would show up with most handles being in LoadState::Loaded and the one typo resulting in a LoadState::Failed
    Error messages would be output from failed load(s)

  • what actually happened?
    LoadedFolder asset for the folder containing one broken asset and many valid assets was never created
    No errors are sent to the console

Additional information

I also noticed that LoadedFolder assets aren't created until all handles within them have completely reached LoadState::Loaded even when everything is going correctly, so you can't check for the progress of the individual assets being loaded. Seems related, but at the very least I think it needs to be created when all handles reach either LoadState::Loaded || LoadState::Failed

@RyeToastyO RyeToastyO added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Nov 9, 2023
@nicopap nicopap added A-Assets Load files from disk to use for things like images, models, and sounds and removed S-Needs-Triage This issue needs to be labelled labels Nov 10, 2023
@RyeToastyO
Copy link
Author

Looks like the error reporting portion of this is being tracked separately in #10515

@RyeToastyO
Copy link
Author

Sorry, hit the wrong button on mobile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Assets Load files from disk to use for things like images, models, and sounds C-Bug An unexpected or incorrect behavior
Projects
None yet
Development

No branches or pull requests

2 participants