Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Asset loading errors are not reported when using load_untyped or load_folder #10515

Closed
juh9870 opened this issue Nov 11, 2023 · 1 comment · Fixed by #10578
Closed

Asset loading errors are not reported when using load_untyped or load_folder #10515

juh9870 opened this issue Nov 11, 2023 · 1 comment · Fixed by #10578
Labels
A-Assets Load files from disk to use for things like images, models, and sounds C-Bug An unexpected or incorrect behavior
Milestone
0.12.1

Comments

@juh9870
Copy link

juh9870 commented Nov 11, 2023

Bevy version

0.12.0

What you did

I was writing an asset loading system for my game.

What went wrong

When using asset_server.load_untyped or asset_server.load_folder, in case of asset loading failure, error is completely discarded without logging or reporting in any way, unlike asset_server.load::<MyAssetType>, which reports an error via tracing crate

Additional information

Places where errors go to die silently disappear without reporting:

bevy/crates/bevy_asset/src/server/mod.rs

Line 349 in c505610

Err(_) => server.send_asset_event(InternalAssetEvent::Failed { id }),

bevy/crates/bevy_asset/src/server/mod.rs

Line 626 in c505610

Err(_) => server.send_asset_event(InternalAssetEvent::Failed { id }),

@juh9870 juh9870 added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Nov 11, 2023
@cart cart added this to the 0.12.1 milestone Nov 11, 2023
@cart
Copy link
Member

cart commented Nov 11, 2023

Good catch. Seems like a straightforward fix!

@alice-i-cecile alice-i-cecile added A-Assets Load files from disk to use for things like images, models, and sounds and removed S-Needs-Triage This issue needs to be labelled labels Nov 12, 2023
@NiklasEi NiklasEi mentioned this issue Nov 13, 2023
Closed
@RyeToastyO RyeToastyO mentioned this issue Nov 15, 2023
Open
@cart cart mentioned this issue Nov 16, 2023
Merged
@nicopap nicopap mentioned this issue Nov 16, 2023
Open
45 tasks
github-merge-queue bot pushed a commit that referenced this issue Nov 16, 2023
@cart
Add missing asset load error logs for load_folder and load_untyped (#…
c7f5cec 
…10578)

# Objective

Fixes #10515 

## Solution

Add missing error logs.
@NiklasEi NiklasEi mentioned this issue Nov 23, 2023
Closed
cart added a commit that referenced this issue Nov 30, 2023
@cart
Add missing asset load error logs for load_folder and load_untyped (#…
0dee514 
…10578)

# Objective

Fixes #10515 

## Solution

Add missing error logs.
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this issue Jan 9, 2024
@cart
Add missing asset load error logs for load_folder and load_untyped (b…
d7560b4 
…evyengine#10578)

# Objective

Fixes bevyengine#10515 

## Solution

Add missing error logs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Assets Load files from disk to use for things like images, models, and sounds C-Bug An unexpected or incorrect behavior
Projects
None yet
Milestone
0.12.1
Development

Successfully merging a pull request may close this issue.

Add missing asset load error logs for load_folder and load_untyped cart/bevy
3 participants
@cart @alice-i-cecile @juh9870