Skip to content

Commit

Permalink
resolved suggestions
Browse files Browse the repository at this point in the history
  • Loading branch information
Kurt Kühnert committed Oct 29, 2021
1 parent 9fc10e2 commit 78efed6
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 9 deletions.
6 changes: 3 additions & 3 deletions pipelined/bevy_pbr2/src/material.rs
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ bitflags::bitflags! {

/// A material with "standard" properties used in PBR lighting.
/// Standard property values with pictures can be found here
/// `<https://google.github.io/filament/Material%20Properties.pdf>`.
/// <https://google.github.io/filament/Material%20Properties.pdf>.
///
/// May be created directly from a [`Color`] or an [`Image`].
#[derive(Debug, Clone, TypeUuid)]
Expand Down Expand Up @@ -73,7 +73,7 @@ impl Default for StandardMaterial {
emissive: Color::BLACK,
emissive_texture: None,
// This is the minimum the roughness is clamped to in shader code
// See `<https://google.github.io/filament/Filament.html#materialsystem/parameterization/>`
// See <https://google.github.io/filament/Filament.html#materialsystem/parameterization/>
// It's the minimum floating point value that won't be rounded down to 0 in the
// calculations used. Although technically for 32-bit floats, 0.045 could be
// used.
Expand All @@ -84,7 +84,7 @@ impl Default for StandardMaterial {
metallic_roughness_texture: None,
// Minimum real-world reflectance is 2%, most materials between 2-5%
// Expressed in a linear scale and equivalent to 4% reflectance see
// `<https://google.github.io/filament/Material%20Properties.pdf>`
// <https://google.github.io/filament/Material%20Properties.pdf>
reflectance: 0.5,
occlusion_texture: None,
double_sided: false,
Expand Down
3 changes: 2 additions & 1 deletion pipelined/bevy_render2/src/render_graph/graph.rs
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ use std::{borrow::Cow, fmt::Debug};
/// # impl Node for MyNode {
/// # fn run(&self, graph: &mut RenderGraphContext, render_context: &mut RenderContext, world: &World) -> Result<(), NodeRunError> {
/// # unimplemented!()
/// # }}
/// # }
/// # }
/// #
/// let mut graph = RenderGraph::default();
/// graph.add_node("input_node", MyNode);
Expand Down
4 changes: 0 additions & 4 deletions pipelined/bevy_render2/src/render_graph/node_slot.rs
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,6 @@ impl From<Entity> for SlotValue {
/// the render [`Nodes`](super::Node).
///
/// This should not be confused with [`SlotValue`], which actually contains the passed data.
///
/// Slots can have four different types:
/// [`Buffer`](SlotType::Buffer), [`TextureView`](SlotType::TextureView),
/// [`Sampler`](SlotType::Sampler) and [`Entity`](SlotType::Entity).
#[derive(Debug, Copy, Clone, Eq, PartialEq)]
pub enum SlotType {
/// A GPU-accessible [`Buffer`].
Expand Down
2 changes: 1 addition & 1 deletion pipelined/bevy_render2/src/view/window.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ use bevy_window::{RawWindowHandleWrapper, WindowId, Windows};
use std::ops::{Deref, DerefMut};
use wgpu::TextureFormat;

// Token to ensure a system runs on the main thread.
/// Token to ensure a system runs on the main thread.
#[derive(Default)]
pub struct NonSendMarker;

Expand Down

0 comments on commit 78efed6

Please sign in to comment.