Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gamepads as entities release notes #1762

Merged

Conversation

alice-i-cecile
Copy link
Member

Fixes #1700.

This PR directly adapts the example by @s-puig in bevyengine/bevy#12770 to demonstrate the new API, and the ergonomic improvements over the previous one. Thanks!

Copy link
Contributor

@MiniaczQ MiniaczQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, few smaller one bigger nit

Comment on lines +68 to +69
[`Gamepad`]: https://docs.rs/bevy/0.15.0-rc.2/bevy/input/gamepad/struct.Gamepad.html
[`GamepadSettings`]: https://docs.rs/bevy/0.15.0-rc.2/bevy/input/gamepad/struct.GamepadSettings.html
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to add this to fallible param notes

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review Ready for a maintainer to consider for merging and removed S-Needs-Review labels Nov 3, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Nov 3, 2024
Merged via the queue into bevyengine:main with commit 6b04166 Nov 3, 2024
10 checks passed
@alice-i-cecile alice-i-cecile deleted the gamepads-as-release-notes branch November 3, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Release-Notes S-Ready-For-Final-Review Ready for a maintainer to consider for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write release notes for PR #12770: Implement gamepads as entities
2 participants