Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collecting all asset loaders under new category: Asset Loaders #114

Closed
wants to merge 1 commit into from

Conversation

Weibye
Copy link

@Weibye Weibye commented Jun 12, 2021

Issue

Various asset loaders was spread over 3D and Helpers sections creating inconsistency.

Solution

Move all asset loaders into the new category of Asset Loaders

Unresolved Questions

  • I'm a bit unsure if bevy_prototype_inline_assets belongs in the Asset Loader or Helpers sections

@Weibye
Copy link
Author

Weibye commented Jun 12, 2021

I assume that moving the files to a new folder is all that is required to change the front-end too. If this is not the case, please let me know.

@mockersf
Copy link
Member

mockersf commented Jun 12, 2021

All the asset loader under the 3D section load 3D asset formats, so both before and after your change make sense to me...

The best fix for this would be to change from the single category by asset and to start using tags. This is planned in a (somewhat) near future, but I took a break after the initial migration from Awesome Bevy to Assets to do other things and collect feedback. Other ideas on how to improve the look/feel/usability are welcome, you can see what I plan to do here: bevyengine/bevy-website#159. You're also welcome to take some of those tasks if you feel up to it 😃

@Weibye
Copy link
Author

Weibye commented Jun 12, 2021

Yeah good point!
In that case I'll just leave the PR standing, and instead start poking around with Zola and attempt figuring out support for tags.

@NiklasEi
Copy link
Member

I think without tags the split to "Asset loaders" is confusing. E.g. "bevy_asset_loader" does not contain an actual Asset loader while some plugins like "bevy_kira_audio" do, but it's not their main functionality.

@Weibye
Copy link
Author

Weibye commented Jun 16, 2021

Closing in favor of migrating to a tag-based system on website

@Weibye Weibye closed this Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants