Features: Add C# binary schema constant #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewmd5
requested changes
Sep 25, 2024
Anatoly03
force-pushed
the
features/cs-binary-schema
branch
2 times, most recently
from
62fce4f to
11ef15f
Compare
|
Thank you for the quick review. Here are some additions:
|
Anatoly03
force-pushed
the
features/cs-binary-schema
branch
from
11ef15f to
02ce9d5
Compare
andrewmd5
requested changes
Sep 25, 2024
|
Test are passing LGTM - thank you! Note for future self: implement binary schemas into the C# runtime this week. |
|
Thank you ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request refactors the code in TypeScript's binary schema creation and adds the feature to C#. The refactoring was made because the old code reserved the string extension method
byte[].ConvertToTypeScriptUInt8ArrayInitializer(schemaName), which was abstracted tobyte[].ConvertToString(leftBrace, rightBrace). The new method allows printing out the schema language-independent.This Pull Request was tested with TypeScript and C#.