This repository has been archived by the owner on May 20, 2020. It is now read-only.
Upgrade day #9
Merged
Upgrade day #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karfau
reviewed
Oct 23, 2017
| @@ -28,11 +28,11 @@ | |||
| "devDependencies": { | |||
| "@types/node": "^8.0.30", | |||
| "ts-node": "^3.3.0", | |||
| "tslint": "5.7.0", | |||
| "tslint": "5.8.0", | |||
There was a problem hiding this comment.
did you check what changed between versions?
There was a problem hiding this comment.
Yes, I did check. Primarily:
- new features/rules are added which we can discuss if we want to enable them if they are not enabled by default. Maybe separate PR and topic for discussion.
- Some rules were fixed for the bugs and some were enhanced. Was not possible to gauge the impact on our code via quick glance over the list. And while running
tslintwith the new version, I just made sure that it doesn't throw up any new warnings or errors. - While writing the comment, I cross-checked if there was any update on the rule mentioned in strict-boolean-expressions wrongly reports on short-circuit expressions #4 , but seems no update.
- Certain options were deprecated on CLI which they plan to remove in further releases.
karfau
approved these changes
Oct 23, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@types/nodefrom 8.0.30 to 8.0.46 8.0.46tslintfrom 5.7.0 to 5.8.0tsutilsfrom 2.8.2 to 2.12.1typescriptfrom 2.5.2 to 2.5.3