Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(node): migrate to v18 #405

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

build(node): migrate to v18 #405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
uses: actions/setup-node@v3
with:
cache: yarn
node-version: 16
node-version: 18
- name: Install
run: yarn
- name: Lint
Expand All @@ -33,7 +33,7 @@ jobs:
uses: actions/setup-node@v3
with:
cache: yarn
node-version: 16
node-version: 18
- name: Install
run: yarn
- name: Lint
Expand All @@ -49,7 +49,7 @@ jobs:
uses: actions/setup-node@v3
with:
cache: yarn
node-version: 16
node-version: 18
- name: Install
run: yarn
- name: Test
Expand Down Expand Up @@ -104,7 +104,7 @@ jobs:
uses: actions/setup-node@v3
with:
cache: yarn
node-version: 16
node-version: 18
- name: Install
run: yarn --frozen-lockfile --production=false
- name: Install Playwright browsers
Expand Down
6 changes: 3 additions & 3 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@

### Requirements

- [Node.js](https://nodejs.org)
- [Yarn](https://yarnpkg.com/getting-started/install)
- [Docker](https://www.docker.com/get-started)
- [Node.js](https://nodejs.org) v18 (with npm v8)
- [Yarn](https://yarnpkg.com/getting-started/install) v1.22
- [Docker](https://www.docker.com/get-started) >= v20

### First Setup

Expand Down
5 changes: 3 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,9 @@
"license": "MIT",
"private": true,
"engines": {
"node": "16",
"npm": "8"
"node": "18",
"npm": "8",
"yarn": "1.22"
},
"scripts": {
"prebuild": "sh ./scripts/build/prebuild.sh",
Expand Down