Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update receiver.html #3778

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Update receiver.html #3778

merged 1 commit into from
Jan 29, 2024

Conversation

ot0tot
Copy link
Contributor

@ot0tot ot0tot commented Jan 29, 2024

It is not clear from the dropdown what FrSky / Futaba / Hitec and Spektrum / Graupner / JR refer to. This PR adds the channel map to the dropdown.
e.g. Spektrum / Graupner / JR becomes Spektrum / Graupner / JR (TAER1234)

Add channel map to options list.
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@haslinghuis haslinghuis added this to the 10.10.0 milestone Jan 29, 2024
@haslinghuis
Copy link
Member

image

Default is the same as second option (FrySky, Futaba, Hitec) 🤨

Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unsure this is needed. but does not hurt i suppose.
once selected the field already reports one or the other, rather conclusively.

@haslinghuis haslinghuis merged commit fceef98 into betaflight:master Jan 29, 2024
7 checks passed
@ot0tot
Copy link
Contributor Author

ot0tot commented Jan 30, 2024

unsure this is needed. but does not hurt i suppose. once selected the field already reports one or the other, rather conclusively.

Having the channel map appear in the list helps when providing support and asking the user to e.g. "change the channel map to AEETR1234". Especially for new users, it's not clear what to select.

Thanks for merging!

@ot0tot ot0tot deleted the patch-1 branch January 30, 2024 14:52
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
Add channel map to options list.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

3 participants