Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve messaging on motors tab #3753

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Improve messaging on motors tab #3753

merged 2 commits into from
Jan 29, 2024

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Jan 14, 2024 •
edited
Loading

image

@haslinghuis haslinghuis added this to the 10.10.0 milestone Jan 14, 2024
@haslinghuis haslinghuis self-assigned this Jan 14, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis changed the title Improve messaging on motors tab Improve messaging on motors tab and reshuffle Jan 14, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@HThuren
Copy link
Member

HThuren commented Jan 14, 2024

image

@nerdCopter
Copy link
Member

nerdCopter commented Jan 16, 2024 •
edited
Loading

i would personally prefer only change motorsNotice as you did. i would prefer not change wording of motorsEnableControl or maybe only make it red. i would prefer not to change layout.

@haslinghuis haslinghuis force-pushed the clarify-motor-testing branch 2 times, most recently from 5ce4c50 to a4c4992 Compare January 16, 2024 16:39
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 16, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis changed the title Improve messaging on motors tab and reshuffle Improve messaging on motors tab Jan 16, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@HThuren
Copy link
Member

HThuren commented Jan 16, 2024

@haslinghuis how to become a approver ?
If I could, I will approve :-)

ctzsnooze
ctzsnooze reviewed Jan 18, 2024
View reviewed changes
locales/en/messages.json
@@ -2995,7 +2995,7 @@
"message": "Master"
},
"motorsNotice": {
"message": "<strong>Motor Test Mode / Arming Notice:</strong><br />Moving the sliders or arming your craft with the transmitter will cause the motors to <strong>spin up</strong>.<br />In order to prevent injury <strong class=\"message-negative\">remove ALL propellers</strong> before using this feature.<br />Enabling motor test mode will also temporarily disable Runaway Takeoff Prevention, to stop it from disarming the craft when bench testing without propellers.<br />"
"message": "<strong>Motor Test Mode / Arming Notice:</strong><br /><br /><strong class=\"message-negative\">WARNING: Serious risk of injury! Remove all propellers!</strong><br /><br /><ul><li>&#x2022; Motors will spin up when armed or when sliders are raised</li><li>&#x2022; Runaway Takeoff Protection will be disabled</li><li>&#x2022; Motor test mode will remain active after moving to another Tab</li><li>&#x2022; Hitting any key will stop the motors, but only in the Motors Tab</li><li>&#x2022; Disconnecting the USB cable may not stop the motors!</li></ul>"
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not really necessary to mention Runaway Takeoff Prevention in this text block, because:
a) if Runaway Takeoff Prevention was active, it would be impossible to use the motors tab, and
b) We mention disabling Runaway Takeoff Prevention being disabled the text about accepting the changes.
No need to say it twice. Let's keep the text as concise as possible

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 18, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@nerdCopter
Copy link
Member

118af020
image

HThuren
HThuren approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@HThuren HThuren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apporiate change, Just to save space,. remove the blank between Red line and bullets below.

@haslinghuis haslinghuis merged commit 86eef99 into betaflight:master Jan 29, 2024
8 checks passed
@haslinghuis haslinghuis deleted the clarify-motor-testing branch January 29, 2024 22:05
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
@haslinghuis @chmelevskij
Improve messaging on motors tab (betaflight#3753)
1e027e4 
* Improve messaging on motors tab

* Update messages.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nerdCopter nerdCopter nerdCopter approved these changes

@HThuren HThuren HThuren approved these changes

@ctzsnooze ctzsnooze Awaiting requested review from ctzsnooze

@McGiverGim McGiverGim Awaiting requested review from McGiverGim

@chmelevskij chmelevskij Awaiting requested review from chmelevskij

Assignees

@haslinghuis haslinghuis

Labels
RN: UI
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@haslinghuis @HThuren @nerdCopter @ctzsnooze