-
-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve messaging on motors tab #3753
Improve messaging on motors tab #3753
Conversation
haslinghuis
commented
Jan 14, 2024
•
edited
Loading
edited
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
d4ae068
to
7b03b49
Compare
This comment has been minimized.
This comment has been minimized.
i would personally prefer only change |
5ce4c50
to
a4c4992
Compare
Please retry analysis of this Pull-Request directly on SonarCloud |
a4c4992
to
1e32b26
Compare
This comment has been minimized.
This comment has been minimized.
1e32b26
to
66d1165
Compare
This comment has been minimized.
This comment has been minimized.
@haslinghuis how to become a approver ? |
@@ -2995,7 +2995,7 @@ | |||
"message": "Master" | |||
}, | |||
"motorsNotice": { | |||
"message": "<strong>Motor Test Mode / Arming Notice:</strong><br />Moving the sliders or arming your craft with the transmitter will cause the motors to <strong>spin up</strong>.<br />In order to prevent injury <strong class=\"message-negative\">remove ALL propellers</strong> before using this feature.<br />Enabling motor test mode will also temporarily disable Runaway Takeoff Prevention, to stop it from disarming the craft when bench testing without propellers.<br />" | |||
"message": "<strong>Motor Test Mode / Arming Notice:</strong><br /><br /><strong class=\"message-negative\">WARNING: Serious risk of injury! Remove all propellers!</strong><br /><br /><ul><li>• Motors will spin up when armed or when sliders are raised</li><li>• Runaway Takeoff Protection will be disabled</li><li>• Motor test mode will remain active after moving to another Tab</li><li>• Hitting any key will stop the motors, but only in the Motors Tab</li><li>• Disconnecting the USB cable may not stop the motors!</li></ul>" | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not really necessary to mention Runaway Takeoff Prevention in this text block, because:
a) if Runaway Takeoff Prevention was active, it would be impossible to use the motors tab, and
b) We mention disabling Runaway Takeoff Prevention being disabled the text about accepting the changes.
No need to say it twice. Let's keep the text as concise as possible
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Do you want to test this code? Here you have an automated build: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apporiate change, Just to save space,. remove the blank between Red line and bullets below.
* Improve messaging on motors tab * Update messages.json