-
-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix language selection #3713
Fix language selection #3713
Conversation
This comment has been minimized.
This comment has been minimized.
AUTOMERGE: (FAIL)
|
src/js/tabs/landing.js
Outdated
@@ -38,7 +38,7 @@ landing.initialize = function (callback) { | |||
bottomSection.append(` <a href="#" lang="${element}" i18n="language_${element}"></a>`); | |||
}); | |||
|
|||
bottomSection.find('a').each((index) => { | |||
bottomSection.find('a').each(function(index) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bottomSection.find('a').each(function(index) { | |
bottomSection.find('a').each((index, element) => { |
src/js/tabs/landing.js
Outdated
@@ -38,7 +38,7 @@ landing.initialize = function (callback) { | |||
bottomSection.append(` <a href="#" lang="${element}" i18n="language_${element}"></a>`); | |||
}); | |||
|
|||
bottomSection.find('a').each((index) => { | |||
bottomSection.find('a').each(function(index) { | |||
let element = $(this); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let element = $(this); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both suggestions did not work :(
Arrow functions and this
don't get along
Reverted and it works again
b20d30e
to
91521c0
Compare
This comment has been minimized.
This comment has been minimized.
src/js/tabs/landing.js
Outdated
@@ -38,7 +38,7 @@ landing.initialize = function (callback) { | |||
bottomSection.append(` <a href="#" lang="${element}" i18n="language_${element}"></a>`); | |||
}); | |||
|
|||
bottomSection.find('a').each((index) => { | |||
bottomSection.find('a').each(function(index) { | |||
let element = $(this); | |||
element.click(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
element.click(() => { | |
$(element).click(() => { |
Also need to change this (if passing the param).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
This one is ok, can change language. |
91521c0
to
64a1c95
Compare
64a1c95
to
1ebed15
Compare
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Do you want to test this code? Here you have an automated build: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1ebed155
works.
No description provided.