Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MSP2_SENSOR_CONFIG_ACTIVE message #3644

Merged
merged 3 commits into from
Nov 28, 2023
Merged

Add MSP2_SENSOR_CONFIG_ACTIVE message #3644

merged 3 commits into from
Nov 28, 2023

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Nov 26, 2023 •
edited
Loading

See: betaflight/betaflight#13177

  • This improves information as we can observe a sensor is included in cloud build, disabled or detected.
  • Added separate Sensor Info panel.

image

@haslinghuis haslinghuis added this to the 10.10.0 milestone Nov 26, 2023
@haslinghuis haslinghuis self-assigned this Nov 26, 2023
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@blckmn
Copy link
Member

blckmn commented Nov 26, 2023 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis haslinghuis force-pushed the add-message-detected-sensors branch 2 times, most recently from 0c6ec81 to 84566d6 Compare November 26, 2023 20:52
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis force-pushed the add-message-detected-sensors branch 2 times, most recently from e77d9cf to e181b41 Compare November 26, 2023 21:19
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis force-pushed the add-message-detected-sensors branch 3 times, most recently from 75bd28d to 00f5621 Compare November 26, 2023 22:52
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 27, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 11 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@github-actions GitHub Actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@nerdCopter

This comment was marked as outdated.

Sign in to view
@nerdCopter
Copy link
Member

56f1f942 with #13177
image
https://build.betaflight.com/api/builds/88b72560782fed6f5dd754e7c0d60df2/json

@haslinghuis haslinghuis merged commit 63c188a into betaflight:master Nov 28, 2023
8 of 9 checks passed
@haslinghuis haslinghuis deleted the add-message-detected-sensors branch November 28, 2023 09:55
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
@haslinghuis @chmelevskij
Add MSP2_SENSOR_CONFIG_ACTIVE message (betaflight#3644)
6b79495 
* Add message for detected sensors

* Add gyro sensor info

* Add separate sensor info panel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctzsnooze ctzsnooze ctzsnooze approved these changes

@nerdCopter nerdCopter nerdCopter approved these changes

@McGiverGim McGiverGim Awaiting requested review from McGiverGim

@chmelevskij chmelevskij Awaiting requested review from chmelevskij

@asizon asizon Awaiting requested review from asizon

Assignees

@haslinghuis haslinghuis

Labels
RN: IMPROVEMENT
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@haslinghuis @blckmn @nerdCopter @ctzsnooze