Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort and translate font name at OSD tab #3621

Merged
merged 3 commits into from
Nov 1, 2023
Merged

Sort and translate font name at OSD tab #3621

merged 3 commits into from
Nov 1, 2023

Conversation

HThuren
Copy link
Member

@HThuren HThuren commented Oct 30, 2023 •
edited
Loading

  • Translate font name
  • Sort optionlist for fonts at OSD tab by translated name

Now:
image
image

Before:
image
image

@github-actions

This comment has been minimized.

Sign in to view
@blckmn
Copy link
Member

blckmn commented Oct 31, 2023 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@haslinghuis haslinghuis added this to the 10.10.0 milestone Oct 31, 2023
@nerdCopter
Copy link
Member

i dont think this is necessary. it separates Large and Extra Large and it also moves Default from the top. (only looking at screencap, did not test.)
image

@HThuren
Copy link
Member Author

HThuren commented Oct 31, 2023

@nerdCopter
Default are placed in top by the sort function.
And I rename Extra Large to "Large Extra", that will do

@nerdCopter
Copy link
Member

well Default not on top of list for Preview. but is correctly first for Font manager.
image

If this PR is importatnt, then maybe a suggest, remove Font -text from selections, and instead insert the word Font into the HTML in from of the drop-down list. 🤷‍♂️ However such may require more i18n language entries.

Mockup:
image

@HThuren
Copy link
Member Author

HThuren commented Nov 1, 2023

I give it a try :-)

@HThuren
Copy link
Member Author

HThuren commented Nov 1, 2023 •
edited
Loading

Now
image

@nerdCopter you where right regarding Default was not at top in Preview, wrong parameter used. I hope fixed for now. Good catch.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2023

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@HThuren
Copy link
Member Author

HThuren commented Nov 1, 2023

@nerdCopter approval ? :-)

@haslinghuis haslinghuis merged commit 111b368 into betaflight:master Nov 1, 2023
9 checks passed
@HThuren HThuren deleted the translateFontName branch November 1, 2023 20:21
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
@HThuren @chmelevskij
Sort and translate font name at OSD tab (betaflight#3621)
9a6cdbb 
* Translate font name in OSD tab

* minor changes

* minor changes 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haslinghuis haslinghuis haslinghuis approved these changes

@nerdCopter nerdCopter nerdCopter approved these changes

Assignees

@HThuren HThuren

Labels
RN: UI
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@HThuren @blckmn @nerdCopter @haslinghuis