Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LED Strip sliders #3550

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Add LED Strip sliders #3550

merged 1 commit into from
Sep 5, 2023

Conversation

ASDosjani
Copy link
Contributor

@ASDosjani ASDosjani commented Aug 18, 2023 •
edited by nerdCopter
Loading

Resubmitting #3531 with MSP2 commands and semver check.

REQUIRES Betaflight PR: betaflight/betaflight#12995

@sonarcloud
Copy link

sonarcloud bot commented Aug 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@ASDosjani ASDosjani mentioned this pull request Aug 18, 2023
Merged
@blckmn
Copy link
Member

blckmn commented Aug 19, 2023 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@haslinghuis haslinghuis added this to the 10.10.0 milestone Aug 19, 2023
@nerdCopter
Copy link
Member

  • smart use of semver 🧠 😍
  • UI testing is on my to-do list (no hardware though)

@nerdCopter
Copy link
Member

nerdCopter commented Aug 21, 2023 •
edited
Loading

  • 230af095 seems to work for UI portion.
  • tested un-soldered foxeerf405 with firmware 4.4.3 and with PR#12995, both acted as expected.

@haslinghuis haslinghuis merged commit 2406205 into betaflight:master Sep 5, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haslinghuis haslinghuis haslinghuis approved these changes

@nerdCopter nerdCopter nerdCopter approved these changes

Assignees

@ASDosjani ASDosjani

Labels
Needs coordination with firmware RN: IMPROVEMENT
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ASDosjani @blckmn @nerdCopter @haslinghuis