-
-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix intermittent connect failure #3515
Fix intermittent connect failure #3515
Conversation
dd4343d
to
0c69452
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Do you want to test this code? Here you have an automated build: |
AUTOMERGE: (FAIL)
|
@@ -761,7 +761,7 @@ export function reinitializeConnection(callback) { | |||
clearInterval(reconnect); | |||
gui_log(i18n.getMessage('deviceReady')); | |||
|
|||
if (callback === typeof('function')) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested good
Fixing some errors which are intermittent and sometimes hard to produce
reinitializeConnection
function had wrong condition.verifyBoard
function if connection is still active. (patience does)writeConfiguration
helper function.