Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sponsor tile to firmware flashing tab #3468

Merged
merged 3 commits into from
Jun 5, 2023

Conversation

blckmn
Copy link
Member

@blckmn blckmn commented Jun 4, 2023

Still need to finalise the Html:

  1. To centre the images,
  2. Add a title "our sponsors" or similar.

Note the above is independent of this PR (as it is loaded into the API).

@github-actions

This comment has been minimized.

@blckmn
Copy link
Member Author

blckmn commented Jun 4, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis haslinghuis added this to the 10.10.0 milestone Jun 4, 2023
@github-actions

This comment has been minimized.

@sonarcloud
Copy link

sonarcloud bot commented Jun 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.9% 0.9% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2023

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@sugaarK
Copy link
Member

sugaarK commented Jun 5, 2023

I can see the window for the sponser bar.. what do we need to do to get it working @blckmn

@blckmn
Copy link
Member Author

blckmn commented Jun 5, 2023

I can see the window for the sponser bar.. what do we need to do to get it working @blckmn

Some html tidy up :) possibly detection between dark and light mode... not sure if we should do that in the app or API...

@haslinghuis haslinghuis merged commit 0e4224e into betaflight:master Jun 5, 2023
@TheIsotopes
Copy link
Contributor

@blckmn @haslinghuis I don't think this was intentional. Can someone please change this.

Screenshot 2023-06-06 095612

@haslinghuis
Copy link
Member

Oops this was not intentional.

400

@KarateBrot
Copy link
Member

KarateBrot commented Jun 6, 2023

Why did you guys just approve and merge the PR? Guys, please think and check before you approve. The PR wasn't even ready yet but you approved and merged immediately 😅

@TheIsotopes
Copy link
Contributor

working now ... thx @haslinghuis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

5 participants