Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: writeConfiguration #3444

Merged
merged 2 commits into from
May 10, 2023
Merged

Refactor: writeConfiguration #3444

merged 2 commits into from
May 10, 2023

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented May 7, 2023 •
edited
Loading

Functions have been refactored to be defined in one place only:

MspHelper.prototype.writeConfiguration = function(bool reboot)

Add a new mspHelper for MSP_EEPROM_WRITE and optional MSP_SET_REBOOT to finish callback reinitializeConnection.

@haslinghuis haslinghuis added this to the 10.10.0 milestone May 7, 2023
@haslinghuis haslinghuis self-assigned this May 7, 2023
@haslinghuis haslinghuis force-pushed the refactor-writeconfiguration branch from 571f9d6 to 884b29e Compare May 7, 2023 22:55
@github-actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis changed the title Refactor writeConfiguration Refactor: writeConfiguration May 7, 2023
@blckmn
Copy link
Member

blckmn commented May 8, 2023 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

McGiverGim
McGiverGim approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@McGiverGim McGiverGim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but for next PRs I would like to have some kind of description in the PR. Latelly we are letting it empty and some PRs, like this, are not basic and a description/explanation helps.

@haslinghuis
Copy link
Member Author

@McGiverGim added description.

@haslinghuis haslinghuis force-pushed the refactor-writeconfiguration branch from 884b29e to 34b6c04 Compare May 10, 2023 14:51
@github-actions

This comment has been minimized.

Sign in to view
@nerdCopter
Copy link
Member

nerdCopter commented May 10, 2023 •
edited
Loading

34b6c04a

the following tabs have unexpected reboot, upon save.

  • Power
  • Modes
  • Video Transmitter
  • LED Strip

@haslinghuis haslinghuis force-pushed the refactor-writeconfiguration branch from 3842d81 to 13c07de Compare May 10, 2023 16:31
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

nerdCopter
nerdCopter approved these changes May 10, 2023
View reviewed changes
Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 13c07de8 works overall for unsoldered FC.
  • might suggest others test further.

@haslinghuis haslinghuis merged commit c5ddfa4 into betaflight:master May 10, 2023
@haslinghuis haslinghuis deleted the refactor-writeconfiguration branch May 10, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nerdCopter nerdCopter nerdCopter approved these changes

@McGiverGim McGiverGim McGiverGim approved these changes

@chmelevskij chmelevskij Awaiting requested review from chmelevskij

Assignees

@haslinghuis haslinghuis

Labels
RN: REFACTOR
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@haslinghuis @blckmn @nerdCopter @McGiverGim