Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: arm status [icon] #3438

Merged
merged 1 commit into from
May 9, 2023
Merged

Fix: arm status [icon] #3438

merged 1 commit into from
May 9, 2023

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented May 4, 2023 •
edited
Loading

  • Loading setup tab is faster then status polling can fill the data so arming-disable-flags was not set at first load.
  • Armedicon was not working due to CSS bug.
  • Motor test was allowed to switch tabs before for testing purposes, now it again picks up status upon re-entering the tab.

@haslinghuis haslinghuis added this to the 10.10.0 milestone May 4, 2023
@haslinghuis haslinghuis self-assigned this May 4, 2023
@github-actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis force-pushed the fix-icon-status branch 2 times, most recently from dd86b3f to 99851b3 Compare May 4, 2023 22:54
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis force-pushed the fix-icon-status branch 2 times, most recently from 1c5a40d to 4faa775 Compare May 5, 2023 00:17
@github-actions

This comment has been minimized.

Sign in to view
@blckmn
Copy link
Member

blckmn commented May 5, 2023 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

nerdCopter
nerdCopter approved these changes May 5, 2023
View reviewed changes
Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • approving. looks good, but i cannot test the arming icon

@haslinghuis haslinghuis force-pushed the fix-icon-status branch 2 times, most recently from 094e1a1 to 310cc37 Compare May 6, 2023 20:04
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis force-pushed the fix-icon-status branch 8 times, most recently from 9b66f7a to 4505729 Compare May 7, 2023 01:09
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@nerdCopter nerdCopter self-requested a review May 7, 2023 16:45
@github-actions

This comment has been minimized.

Sign in to view
@haslinghuis
Copy link
Member Author

Moved the refactoring part to a new PR to ease reviewing.

@github-actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis changed the title Fix status Fix: status [icon] May 7, 2023
@haslinghuis haslinghuis changed the title Fix: status [icon] Fix: arm status [icon] May 7, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 7, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
4.5% 4.5% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2023

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

nerdCopter
nerdCopter approved these changes May 8, 2023
View reviewed changes
Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • approving, tested well.
  • however, i cannot test arming icon on unsoldered FC.

@haslinghuis haslinghuis requested a review from McGiverGim May 8, 2023 20:29
@haslinghuis haslinghuis merged commit e789d97 into betaflight:master May 9, 2023
@haslinghuis haslinghuis deleted the fix-icon-status branch May 9, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nerdCopter nerdCopter nerdCopter approved these changes

@McGiverGim McGiverGim McGiverGim approved these changes

Assignees

@haslinghuis haslinghuis

Labels
RN: BUGFIX
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@haslinghuis @blckmn @McGiverGim @nerdCopter