Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show CPU core temp on Setup tab #3403

Merged
merged 2 commits into from
Apr 6, 2023
Merged

Conversation

HThuren
Copy link
Member

@HThuren HThuren commented Apr 5, 2023

From API 1.46, get CPU temperature from betaflight firmware by new record in MSP_STATUS_EX
Depends of betaflight PR 12608

Also read configState flags, found in betaflight msp.c, but not read in betaflight_configurator MSPHelper.js
This record are older than Nov 16, 2019

Screenshot, temperature at last line:
image

@sonarcloud
Copy link

sonarcloud bot commented Apr 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@blckmn
Copy link
Member

blckmn commented Apr 5, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@nerdCopter
Copy link
Member

If OSD units is imperial, then Fahrenheit maybe?

@HThuren
Copy link
Member Author

HThuren commented Apr 6, 2023

If OSD units is imperial, then Fahrenheit maybe?

well well, but are a setting for OSD, cli status command give C, soee
I suggest this as a next step, a setting for configurator controlling unit :-)

@nerdCopter
Copy link
Member

If OSD units is imperial, then Fahrenheit maybe?

well well, but are a setting for OSD, cli status command give C, soee I suggest this as a next step, a setting i configurator controlling unit :-)

that's fair, no need to add another betaflight setting

@haslinghuis haslinghuis merged commit e15cb55 into betaflight:master Apr 6, 2023
@HThuren HThuren deleted the getCoreTemp branch April 6, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

4 participants