Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load available cloud build options when selecting the firmware version to build #3384

Merged
merged 3 commits into from
Mar 20, 2023
Merged

Load available cloud build options when selecting the firmware version to build #3384

merged 3 commits into from
Mar 20, 2023

Conversation

blckmn
Copy link
Member

@blckmn blckmn commented Mar 18, 2023

Options can now be adjusted upon each release.

@blckmn blckmn self-assigned this Mar 18, 2023
@blckmn blckmn added this to the 10.10.0 milestone Mar 18, 2023
@github-actions

This comment has been minimized.

Sign in to view
@blckmn
Copy link
Member Author

blckmn commented Mar 18, 2023 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> PASS
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

haslinghuis
haslinghuis previously approved these changes Mar 18, 2023
View reviewed changes
@haslinghuis haslinghuis requested a review from nerdCopter March 19, 2023 01:17
@nerdCopter
Copy link
Member

something wrong with this. i can only auto-detect once.
https://youtu.be/8Zdcaw5bZdw

@haslinghuis haslinghuis dismissed their stale review March 19, 2023 18:00

Needs testing

@blckmn
Copy link
Member Author

blckmn commented Mar 20, 2023

something wrong with this. i can only auto-detect once. https://youtu.be/8Zdcaw5bZdw

I don't think this is the cause of this problem. The change here is nothing to do with Autodetect, it merely moves the population of the options to "after" the selection of the firmware release, but before the slide out occurs.

@haslinghuis
Copy link
Member

image

@github-actions

This comment has been minimized.

Sign in to view
@blckmn
Copy link
Member Author

blckmn commented Mar 20, 2023

Actually I'll need to make that change... otherwise the presets will get blown away

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.0% 1.0% Duplication

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

nerdCopter
nerdCopter approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • tested. seems to doing what is expected.

@haslinghuis haslinghuis merged commit 95f4c6e into betaflight:master Mar 20, 2023
haslinghuis
haslinghuis reviewed Mar 20, 2023
View reviewed changes
src/js/tabs/firmware_flasher.js
self.releaseLoader.loadOptionsByBuildKey(release, FC.CONFIG.buildKey, buildOptions);
} else {
self.releaseLoader.loadOptions(release, buildOptions);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@blckmn blckmn deleted the release-cloudoptions branch March 21, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haslinghuis haslinghuis haslinghuis approved these changes

@nerdCopter nerdCopter nerdCopter approved these changes

Assignees

@blckmn blckmn

Labels
RN: IMPROVEMENT Tested
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@blckmn @nerdCopter @haslinghuis