Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mDNS browser #3337

Merged
merged 1 commit into from
Feb 15, 2023
Merged

Fix mDNS browser #3337

merged 1 commit into from
Feb 15, 2023

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Feb 10, 2023 •
edited
Loading

Fixes: #3336

Also mDSN browser in PortHandler is now disabled by default. Please use options tab to enable the feature.

@haslinghuis haslinghuis added this to the 10.10.0 milestone Feb 10, 2023
@haslinghuis haslinghuis self-assigned this Feb 10, 2023
@github-actions

This comment has been minimized.

Sign in to view
@Schlaegel
Copy link

This works for me!!!! W00H000! It's the first time 10.9 or 10.10 has worked. I tested it both with MDNS and without MDNS. Both worked. (The title is incorrectly labeled MSDN, which brings back memories of the Microsoft Developer Network and my career many decades ago.)

Thanks

@haslinghuis haslinghuis changed the title Fix MSDN browser Fix mDSN browser Feb 11, 2023
@haslinghuis
Copy link
Member Author

Updated labels to mDSN

@github-actions

This comment has been minimized.

Sign in to view
@Schlaegel
Copy link

Almost. It's mDNS. Like regular DNS (Domain Name System) but with a lower case 'm' in front for multicast.

@haslinghuis
Copy link
Member Author

Fixed.

@github-actions

This comment has been minimized.

Sign in to view
@blckmn
Copy link
Member

blckmn commented Feb 11, 2023 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> PASS
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

nerdCopter
nerdCopter approved these changes Feb 11, 2023
View reviewed changes
Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Although i cannot test any network/wifi, i verify that this does not break any USB usage. I can connect USB with the mDNS toggle on or off. (Ubuntu 22.04.1 LTS)

@haslinghuis haslinghuis changed the title Fix mDSN browser Fix mdns browser Feb 11, 2023
@haslinghuis haslinghuis changed the title Fix mdns browser Fix mDNS browser Feb 11, 2023
chmelevskij
chmelevskij reviewed Feb 15, 2023
View reviewed changes
src/js/port_handler.js Outdated
}))).flat() ?? []),
].filter(Boolean);
} else {
currentPorts = [ ...cp];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
currentPorts = [ ...cp];
currentPorts = cp;

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
McGiverGim
McGiverGim requested changes Feb 15, 2023
View reviewed changes
src/js/tabs/options.js Outdated Show resolved Hide resolved
src/js/tabs/options.js Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis merged commit ad5b94c into betaflight:master Feb 15, 2023
@haslinghuis haslinghuis deleted the fix-mdsnbrowser branch February 15, 2023 18:34
@haslinghuis haslinghuis mentioned this pull request Mar 24, 2023
Closed
@haslinghuis haslinghuis mentioned this pull request May 7, 2023
Closed
@haslinghuis haslinghuis mentioned this pull request Jun 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chmelevskij chmelevskij chmelevskij left review comments

@nerdCopter nerdCopter nerdCopter approved these changes

@McGiverGim McGiverGim McGiverGim approved these changes

Assignees

@haslinghuis haslinghuis

Labels
Ready to Merge RN: BUGFIX Tested
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.

Ports never finish "Loading..." on Ubuntu 22.04 and 22.10
6 participants
@haslinghuis @Schlaegel @blckmn @McGiverGim @chmelevskij @nerdCopter