Move GPS configuration to GPS tab

[haslinghuis]

No description provided.

[blckmn]

AUTOMERGE: (FAIL)

• github identifies PR as mergeable -> FAIL
• assigned to a milestone -> PASS
• cooling off period lapsed -> PASS
• commit count less or equal to three -> PASS
• Don't merge label NOT found -> PASS
• at least one RN: label found -> PASS
• Tested label found -> FAIL
• assigned to an approver -> PASS
• approver count at least three -> FAIL

[McGiverGim]

Thanks! This is a good move. As always, it will be great some text and some screen capture in the PR ;)

[haslinghuis]

[McGiverGim]

I don't know if the latest place in the page is the best for that, but it's ok to me.

[haslinghuis]

@McGiverGim

Addition to the end seems to be the least intrusive for mobile users.

I might be wrong but after looking at io/gps.c in firmware autobaud and autoconfig are only applicable for UBLOX protocol. Should we hide autobaud and autoconfig for NMEA. Not sure about MSP as this could use both protocols.

[KarateBrot]

I think it would be best to put the GPS configuration first. Example layout:

| GPS Configuration   | GPS                  |
----------------------------------------------
| GPS Signal Strength | Current GPS Location |

[haslinghuis]

[McGiverGim]

I might be wrong but after looking at io/gps.c in firmware autobaud and autoconfig are only applicable for UBLOX protocol. Should we hide autobaud and autoconfig for NMEA. Not sure about MSP as this could use both protocols.

I think you are right. I think remember some PR to add the feature for NMEA but maybe I'm wrong.

[KarateBrot]

I think a grey divider line would be nice here (like in the original configuration window in the "Configuration" tab)

[haslinghuis]

[nerdCopter]

Config-tab's GPS, OSD, LED_STRIP, Transponder not only enable the feature, but also tell the configurator to display the tab or not. With this change, it changes the paradigm. and the GPS tab will always be visible, even on non-GPS builds. Is this wanted? Would the other features follow the new pattern?

[McGiverGim]

Config-tab's GPS, OSD, LED_STRIP, Transponder not only enable the feature, but also tell the configurator to display the tab or not. With this change, it changes the paradigm. and the GPS tab will always be visible, even on non-GPS builds. Is this wanted? Would the other features follow the new pattern?

Maybe we can do it when there is a GPS in the Ports tab selected? @haslinghuis will be difficult to do it this way for the tabs? Now that we enable the features depending if we have it selected at the ports tab.

EDIT: Another option, less fancy, is to have the check to select the feature in the tab, but nothing more, occuping all the width. When enabled, then the rest of options "appear".

[haslinghuis]

The GPS feature is driven by the ports tab sensor input field.
Disabling the feature on the GPS tab leaves the port setting in tact and removes the GPS tab.
To re-enable GPS we have to save and reboot on the Port tab.

Only need to fix when the feature is disabled we don't return to the GPS tab while it's no longer in the menu.

Now features are cloud build user options - this could be a start for removing the feature toggles ???

[McGiverGim]

For this reason I recommended enable and disable features in the "firmware" part and not in the configurator part. If this was done in the firmware part, enable it when GPS selected in the ports tab, and removed when not, we would simply need to remove the toggle from the tab. Now is more difficult, because the user can let the things incoherent if uses CLI or preset to configure some port.

Maybe we can try to remove the toggle from the GPS tab, hopping that any user that wants GPS configures it from the ports tab and not CLI or presets. But this will bit us later or soon.

[haslinghuis]

Moving the feature switch from GPS to configuration tab seems to be most consistent.

For future work thinking about replacing features with port functions but also like to do something with the build config.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

No Coverage information
0.0% Duplication

[github-actions]

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

[KarateBrot]

@haslinghuis
Moving the feature switch from GPS to configuration tab seems to be most consistent.

That makes a lot of sense because GPS is a feature in the BF firmware. It fits right in. 👌

[KarateBrot]

@haslinghuis I think there is a bug. My GPS tab won't show up even if GPS is activated:

[haslinghuis]

@KarateBrot have you enabled GPS on ports tab?

[haslinghuis]

[KarateBrot]

Yes I have "GPS" enabled in the ports tab. I don't have a GPS receiver connected but it should still show me the GPS tab, no?

Edit: Also tested this on another FC with GPS connected but same behavior:

[haslinghuis]

Windows, Linux, OSX ???

Have tested these scenario's with and without GPS on Linux. Cannot reproduce on Linux ?
Using a fresh clone for testing on master

[KarateBrot]

Oh, sure, sorry. It's Windows...

[haslinghuis]

K will check there too, but it's has a much slower processor :)

[haslinghuis]

Working on Windows too (without GPS attached).

Did you build from github? If so might need to clean cache, dist, debug and node_modules.
Did you flash with GPS build option enabled?

[HThuren]

Maybe more alignment

[haslinghuis]

@HThuren - check NMEA and the box resizes as less options are available.

[KarateBrot]

@haslinghuis
Working on Windows too (without GPS attached).

Did you build from github? If so might need to clean cache, dist, debug and node_modules.

I cleaned all these and built again using

yarn install
yarn start

but it still doesn't show up in the tabs. Weird...

Did you flash with GPS build option enabled?

Yes, I did. Otherwise the GPS switch would turn off automatically again and would not stay activated.

Maybe this solves itself at some point. Don't worry about it. Otherwise I will probably hassle you about it sometime in the future. 😀