Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Presets fix: removed old event listener that caused console errors #3183

Merged
merged 1 commit into from
Dec 30, 2022
Merged

Presets fix: removed old event listener that caused console errors #3183

merged 1 commit into from
Dec 30, 2022

Conversation

limonspb
Copy link
Member

@limonspb limonspb commented Dec 29, 2022 •
edited
Loading

Removed a piece of code from the medieval ages that was causing console errors.

The error pointed by @haslinghuis here

@sonarcloud
Copy link

sonarcloud bot commented Dec 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis added this to the 10.9.0 milestone Dec 29, 2022
@blckmn
Copy link
Member

blckmn commented Dec 29, 2022

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@haslinghuis haslinghuis merged commit b0f7ef6 into betaflight:master Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haslinghuis haslinghuis haslinghuis approved these changes

@sugaarK sugaarK sugaarK approved these changes

Assignees

@limonspb limonspb

Labels
RN: BUGFIX
Projects
None yet
Milestone
10.9.0
Development

Successfully merging this pull request may close these issues.
4 participants
@limonspb @blckmn @haslinghuis @sugaarK