Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tab adjustments: Sort the translated optionlist #3152

Merged
merged 4 commits into from
Dec 28, 2022
Merged

Tab adjustments: Sort the translated optionlist #3152

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fbc8d2a
Sort the translated optionlist
HThuren Dec 17, 2022
99bc160
Remoove 22_2 and 23_2
HThuren Dec 17, 2022
2f03d71
Remove 22_2 and 23_2 in messages
HThuren Dec 17, 2022
e9842db
Now use sortSelect in common.js
HThuren Dec 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions src/js/tabs/adjustments.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,14 +303,6 @@ adjustments.adjust_template = function () {
selectFunction.append(new Option(i18n.getMessage(`adjustmentsFunction${i}`), i));
}

// For 1.40, the D Setpoint has been replaced, so we replace it with the correct values
const element22 = selectFunction.find("option[value='22']");
const element23 = selectFunction.find("option[value='23']");

// Change the "text"
element22.text(i18n.getMessage('adjustmentsFunction22_2'));
element23.text(i18n.getMessage('adjustmentsFunction23_2'));

HThuren marked this conversation as resolved.
Show resolved Hide resolved
// Sort the element, if need to group, do it by lexical sort, ie. by naming of (the translated) selection text
selectFunction.sortSelect();
};
Expand Down