Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed unused compass declination setting. #1997

Merged
merged 1 commit into from
May 3, 2020
Merged

Removed unused compass declination setting. #1997

merged 1 commit into from
May 3, 2020

Conversation

mikeller
Copy link
Member

@mikeller mikeller commented May 2, 2020

Fixes #1996.

@mikeller mikeller added this to the 10.7.0 milestone May 2, 2020
@sonarcloud
Copy link

sonarcloud bot commented May 2, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.0% 1.0% Duplication

McGiverGim
McGiverGim approved these changes May 2, 2020
View reviewed changes
Copy link
Member

@McGiverGim McGiverGim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't expect so many changes to remove it 🤗

@mikeller
Copy link
Member Author

mikeller commented May 2, 2020

Well, the follow up from removing compass declination is that the ..._COMPASS_CONFIG MSP commands are now unused and can be removed, leading to a performance improvement when loading / saving the configuration tab.

@mikeller mikeller merged commit 8fd1c11 into betaflight:master May 3, 2020
@mikeller mikeller deleted the remove_mag_declination branch May 3, 2020 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McGiverGim McGiverGim McGiverGim approved these changes

Assignees
No one assigned
Labels
RN: BUGFIX
Projects
None yet
Milestone
10.7.0
Development

Successfully merging this pull request may close these issues.

BF-Conf 10.7.0-RC1: Configuration tab GPS mag_declination Allowed range: -18000 - 18000
2 participants
@mikeller @McGiverGim