-
-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic Idle configurable #1905
Conversation
@asizon: Ignore the Sonar complaints - they are caused by me accidentally disabling, and then re-enabling some detection rules. 😖 |
Yeah this is a bit of a problem: logically it belongs next to dshot_idle_value, but that is on a non profile page. On the other hand dshot_idle_value would really be better suited in a profile so it can be changed according to cell count. Maybe dshot_idle_value should become a profile setting and both be moved to the pid page? |
@joelucid: Agreed, moving Hence I think moving the dynamic idle value into the PID tuning tab is what can be done to address this at the moment. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
I also changed the name of the function of the tab configuration to make it more generic, it didn't occur to me when I did it a while ago. Maybe we should listen to Sonarcloud error |
I am seeing a great effort in joelucid to improve the explanation in the wiki and social networks of how this feature works and I think it now looks better. Adding Dynamic Idle feature configurable parametre. It is a feature that depends on the pidprofile so I have linked this tab with
MSP_PID_ADVANCED
. My first idea is to show in some way that this feature belongs to the pid profile, happy to hear ideas. Also modify the function of hiding values that depend on rpm and unify it. The tooltip needs updating by @joelucid suggestions.