-
-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show warning on connect when ACC is not calibrated. #1903
Show warning on connect when ACC is not calibrated. #1903
Conversation
d56b779
to
95c301a
Compare
Maybe add a comment about the quad will not arm if enabled and not calibrated? |
95c301a
to
5ae4d5a
Compare
@McGiverGim: Is this ok now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, I forgot about it sorry...
5ae4d5a
to
bfc8323
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good!
@mikeller I discovered a bug that occurs right after this commit and I am not able to fix it. From what I have been able to analyze I think the error is inside |
ok, i got it! #1915 |
Presents a warning to the user when connecting if ACC is enabled and not calibrated:
I think this is a better alternative to betaflight/betaflight#9458, as it points the user to the instructions for a correct calibration.
The list of warnings is built dynamically, so that other problems, like insufficient filtering, can be added and displayed as well.