Show warning on connect when ACC is not calibrated. #1903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeller
force-pushed
the
show_acc_calibration_warning
branch
3 times, most recently
from
d56b779
to
95c301a
Compare
|
Maybe add a comment about the quad will not arm if enabled and not calibrated? |
mikeller
force-pushed
the
show_acc_calibration_warning
branch
from
95c301a
to
5ae4d5a
Compare
|
|
|
@McGiverGim: Is this ok now? |
McGiverGim
previously approved these changes
Mar 2, 2020
mikeller
force-pushed
the
show_acc_calibration_warning
branch
from
5ae4d5a
to
bfc8323
Compare
|
Added a check to only report missing acc calibration if ACC is enabled. Also, made the warning a bit more wordy:
|
|
Kudos, SonarCloud Quality Gate passed!
|
|
@mikeller I discovered a bug that occurs right after this commit and I am not able to fix it. From what I have been able to analyze I think the error is inside |
|
ok, i got it! #1915 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presents a warning to the user when connecting if ACC is enabled and not calibrated:
I think this is a better alternative to betaflight/betaflight#9458, as it points the user to the instructions for a correct calibration.
The list of warnings is built dynamically, so that other problems, like insufficient filtering, can be added and displayed as well.