-
-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Motor Output Limit and Profile Cell Count #1901
Conversation
LIMIT: limits the maximum output signal for the motors. In order to use batteries with more cells than those the motor theoretically supports (make sure the electronics supports the voltage). Less than 100% limit causes a linear reduction in the motor drive signal. CELL COUNT: it allows to assign profiles for different type batteries (with different number of cells). Betaflight automatically detects de voltage of the battery when plugged in the quad and it will select the according profile. |
Yes @mikeller ,much better like that, thanks! |
@McGiverGim: What do you think about the Sonar 'bugs' reported on this pull request? |
Until now we have ignored this HTML bugs but we can try to fix them. @asizon can you look at the Sonar link and try to fix them? If you click on the issue there is an explanation about the problem and how to fix it. |
I will try it now! And need to revise the tootltip, what do you think about the above @dridsfpv proposal? |
@McGiverGim: Not 100% sure this is the right approach. Pretty much all of these 'bugs' seem to be aiming at making content and applications available to vision impaired users through screen readers. While this is a good and important thing for general purpose users, I am reasonably sure that there is only very little overlap between users who can not read text on a screen and users who fly racing drones, therefore I am not sure it is good use of time to fix these 'bugs' - maybe we should just ignore them in the sonar config? |
True. We can disable them in Sonar to limit this kind of errors. |
@mikeller what do you think about these ctzsnooze suggested names?? |
@asizon: Looks good to me - I think for these settings it is important that the help texts are good, as the things that are controlled by them are relatively complex. |
This is really great! |
@ctzsnooze: The CLI name is not very good in reality - we should flog they guy who put it in in the first place in betaflight/betaflight#7482 - oh wait. 🤔 |
For the info messages, maybe something like: |
@ctzsnooze: Looks good - we probably don't need the 'LIMIT' / 'CELL COUNT' headers in the tooltip - it is clear enough what they belong to. |
SonarCloud Quality Gate failed. 8 Bugs No Coverage information |
Yes @mikeller i have updated to ctzsnooze suggested texts :) and squashed. Thanks for your text suggestions @ctzsnooze and @dridsfpv |
Fix cell count min Move tootltip`icons Cosmetic changes
9f8c13f
to
7e9cebf
Compare
The new tool tip states: Surely this should read In my mind the current wording implies a value of 100% will attenuate the output by 100% and therefore be zero? |
@Juzzle1: You are correct - calling this 'attenuation' is actually not a good term for it anyway, as this is 'the amount of reduction'. |
I think the term 'limit' is also very confusing, as this suggests a cap on the peak output power, rather than linear scaling. I'd suggest: Frame title: Setting label: Tip text: |
@Juzzle1: Yes, that sounds better - can I get you to open a pull request for these changes? |
For what I can see this is only used in 2 places, |
Yes, i agree that attenuation is wrong and we must change it. But I see that @Juzzle1 also want to change |
'Limit' is also used in the CLI ( |
Added
motor_output_limit
andauto_profile_cell_count
configurable parameters. I know there is no place at all appropriate to add it, happy to hear opinions and discuss this :)