Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug modes to blackbox tab #1566

Merged
merged 2 commits into from
Aug 15, 2019
Merged

Conversation

IvoFPV
Copy link
Contributor

@IvoFPV IvoFPV commented Aug 8, 2019

Fixes #1502
Adds debug mode setting in the blackbox tab. Requires MSP to go with it which will be added.

hydra
hydra previously requested changes Aug 9, 2019
src/js/tabs/onboard_logging.js Outdated Show resolved Hide resolved
src/js/tabs/onboard_logging.js Outdated Show resolved Hide resolved
@McGiverGim
Copy link
Member

@hydra is that ok for you now?

@mikeller mikeller merged commit 5410742 into betaflight:master Aug 15, 2019
@IvoFPV IvoFPV deleted the debugmodesinui branch August 15, 2019 20:11
@hydra
Copy link
Contributor

hydra commented Aug 16, 2019

sorry for late reply on this one @McGiverGim been a busy week yes, that is perfect now.

I did note in another PR recently that the internal debug variables in multiwii/baseflight/cleanflight/betaflight all pre-date blackbox logging and are for developers.

The variables are not specifically for logging, but by adding this to the UI on the blackbox logging page you might think they were for that when this is not the case.

Renaming the setting 'Blackbox debug mode' further confuses this situation.

debug variables are used in the following places:

  1. internally in firmware
  2. readable via msp commands
  3. displayable on OSD.
  4. on 'sensors' page in the configurator UI.
  5. in the blackbox log data.

For a long time I thought about adding this setting to the 'sensors' page in the UI but never got round to it. Perhaps this setting should be moved from the 'Blackbox' page to the 'Sensors' tab, or perhaps it really belongs in the catch-all 'Configuration' page and called 'Debug mode' rather than 'Blackbox debug mode'.

Perhaps the real solution is to allow the user to choose exactly what they want to log in the 4 blackbox log uint16_t placeholders from all available sources and leave 'debug mode' alone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Add Blackbox debug modes to the Blackbox tab.
4 participants