-
-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add debug modes to blackbox tab #1566
Conversation
@hydra is that ok for you now? |
sorry for late reply on this one @McGiverGim been a busy week yes, that is perfect now. I did note in another PR recently that the internal debug variables in multiwii/baseflight/cleanflight/betaflight all pre-date blackbox logging and are for developers. The variables are not specifically for logging, but by adding this to the UI on the blackbox logging page you might think they were for that when this is not the case. Renaming the setting 'Blackbox debug mode' further confuses this situation. debug variables are used in the following places:
For a long time I thought about adding this setting to the 'sensors' page in the UI but never got round to it. Perhaps this setting should be moved from the 'Blackbox' page to the 'Sensors' tab, or perhaps it really belongs in the catch-all 'Configuration' page and called 'Debug mode' rather than 'Blackbox debug mode'. Perhaps the real solution is to allow the user to choose exactly what they want to log in the 4 blackbox log uint16_t placeholders from all available sources and leave 'debug mode' alone. |
Fixes #1502
Adds debug mode setting in the blackbox tab. Requires MSP to go with it which will be added.