Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order OSD elements in alphabetical order #1485

Merged
merged 1 commit into from
Jun 12, 2019

Conversation

McGiverGim
Copy link
Member

Now that we have A LOT of OSD elements to display, is difficult to find them. This PR reorders the elements to appear in alphabetical order, at least, in this way is easier to find them.

image

I'm thinking if it is interesting to translate the texts too to other languages. Thoughts?

@Docteh
Copy link
Contributor

Docteh commented Jun 11, 2019

Can you sort internationalized strings? Or would people be subject to the whims of the English language?

Actually, there is a lot of room in that screenshot. I'd be tempted to float the idea of something like

Core Temperature (Kerntemperatur)

To the non-english speakers.

@McGiverGim
Copy link
Member Author

Yes I can. If it seems interesting I will push a PR later, but I'm not too sure how the sort will work with non ASCII languages, like Chinese or Japanese.

@McGiverGim
Copy link
Member Author

It seems the localeCompare with locale as argument is supported by Chrome so I can test it after this is merged.
More info: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/localeCompare#Browser_compatibility

@mikeller
Copy link
Member

@McGiverGim, @Docteh: This is a good idea, but I agree that this should be made to work with non-latin character sets as well. Also, using an ' ()' pattern (and thus ordering alphabetically in English) is definitely not what we want, as this forces the users to know the English names. If anything, make it ' ()'.

@McGiverGim
Copy link
Member Author

No, my idea is a simple translation, like in the rest of the app, and order by this translation. If translated I don't think we need an English part.
But my idea is merge this first and add the translated in other PR.
@mikeller is ok or is better to do all here?

@mikeller
Copy link
Member

Heh, I just realised that currently the entries in the OSD element list are not translated at all, just the tooltips are.
In this case there is no problem with mergeing this - but we should probably consider translating the OSD element names.

@mikeller mikeller added this to the 10.6.0 milestone Jun 12, 2019
@mikeller mikeller merged commit bb72a44 into betaflight:master Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants