New crash flag in 4.1 jostles the disarm flags #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
McGiverGim
reviewed
May 10, 2019
locales/en/messages.json
Outdated
| @@ -789,6 +789,10 @@ | |||
| "message": "Runway Takeoff Prevention has been triggered", | |||
| "description": "Description of the RUNAWAY_TAKEOFF arming disable flag" | |||
| }, | |||
| "initialSetupArmingDisableFlagsTooltipCRASH": { | |||
| "message": "Ouch!", | |||
There was a problem hiding this comment.
It's funny, but I don't know if this is the correct description :)
I usually took them from here: https://github.com/betaflight/betaflight/wiki/Arming-Sequence-&-Safety but it seems it has neither been added to the wiki.
There was a problem hiding this comment.
"Disarmed via crash detection"
"Apparently, we've crashed"
"Crash has been detected"
Its a fairly recent status flag, that is very unlikely to show on the configurator.
There was a problem hiding this comment.
If we set it to something funny now I am almost certain we will forget to change it back before the next release. "Disarmed via crash detection" sounds good.
There was a problem hiding this comment.
thanks for choosing. :)
mikeller
approved these changes
May 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to betaflight/betaflight@760a524
Note: initialSetupArmingDisableFlagsTooltipCRASH.message might need to get handled somewhere. Maybe people could just not crash with the configurator open...