Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder bind and on: for select (fixes #461) #468

Closed
wants to merge 1 commit into from

Conversation

clemens-tolboom
Copy link

This should fix #461.

@shaun-wild
Copy link

shaun-wild commented Mar 29, 2022

This will fix the issue for select.

Input maps to multiple underlying components, and it still won't work for those.

I'd apply the fix at every point possible in the file (bare in mind there are sub-components referenced in Input that will need the fix applying also i.e FormCheck).

Maybe add a test too?

Oh, I forgot to mention, I've already fixed this on another fork (with tests). I never created a PR though as some of the original tests were failing, the failures seemed unrelated to my changes, however. I can create a PR and save you the work if you like?

@clemens-tolboom
Copy link
Author

@shaun-wild a PR would be great ... we can then close this on.

@shaun-wild
Copy link

I have created the PR.

@clemens-tolboom
Copy link
Author

Closing in favor of #473

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change on:change and bind order in components
2 participants